Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.ddcci-driver: 0.3.2 -> 0.3.3 #84161

Merged
merged 1 commit into from Apr 8, 2020
Merged

linuxPackages.ddcci-driver: 0.3.2 -> 0.3.3 #84161

merged 1 commit into from Apr 8, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

Noticed it was out of date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc. @worldofpeace @bricewge

@ofborg ofborg bot requested a review from bricewge April 3, 2020 05:07
bricewge
bricewge approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@bricewge bricewge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I wont be able to test this PR, but it's content looks good to me.
See https://logs.nix.samueldr.com/nixos/2020-04-03#3264152; for more context.

worldofpeace
worldofpeace suggested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the attr you should be using here is linuxPackages.ddcci-driver in your commit message.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build linuxPackages.ddcci-driver linuxPackages_latest.ddcci-driver

@lovesegfault lovesegfault deleted the ddcci-0.3.3 branch April 7, 2020 07:31
@lovesegfault lovesegfault restored the ddcci-0.3.3 branch April 7, 2020 07:34
@lovesegfault lovesegfault reopened this Apr 7, 2020
@ofborg ofborg bot requested a review from bricewge April 7, 2020 07:42
@worldofpeace worldofpeace changed the title ddcci: 0.3.2 -> 0.3.3 linuxPackages.ddcci-driver: 0.3.2 -> 0.3.3 Apr 8, 2020
@worldofpeace worldofpeace merged commit 9fa5658 into NixOS:master Apr 8, 2020
@lovesegfault lovesegfault deleted the ddcci-0.3.3 branch April 8, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@bricewge bricewge Awaiting requested review from bricewge

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @worldofpeace @bricewge