Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.msgpack: 0.6.2 -> 1.0.0 #80934

Closed
wants to merge 1 commit into from
Closed

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 24, 2020

Motivation for this change

Needed by vimPlugins.deoplete.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NilsIrl
Copy link
Member

NilsIrl commented Feb 24, 2020

#80855

Also how come the hash is different from that PR?

@LnL7
Copy link
Member Author

LnL7 commented Feb 25, 2020

@NilsIrl Thanks for noticing, looks like the default output format changed on nix master.

@jonringer
Copy link
Contributor

also, this appears to cause a fair number of regression in master, if it's just needed by just one program, you can override the python package set when calling into python. (e.g. for the vimplugin)

Updating the default version currently breaks a number of other
packages.
@NilsIrl
Copy link
Member

NilsIrl commented Feb 26, 2020

also, this appears to cause a fair number of regression in master, if it's just needed by just one program, you can override the python package set when calling into python. (e.g. for the vimplugin)

This is literally the problem Nix is supposed to fix

@jonringer
Copy link
Contributor

jonringer commented Feb 26, 2020

This is literally the problem Nix is supposed to fix

@NilsIrl this is more or less specific to python, where there's not many good abstractions for introducing/removing visible packages to the python interpreter.

In other words, python doesn't have a patchelf which is able to make executables refer to their exact dependencies.

@jonringer
Copy link
Contributor

I was able to determine that all the failures were just noise and merged #80855

@jonringer
Copy link
Contributor

unfortunately, the python package set can't really handle many version at the same time. The package set become incoherent if they are present in the same environment. (only one will be imported, and other other will not)

@jonringer
Copy link
Contributor

jonringer commented Feb 26, 2020

In my original comment, I meant to edit the vimPlugins.deoplete so that the python3 interpreter it has would contain a package set specific to the vim plugin.

@LnL7
Copy link
Member Author

LnL7 commented Feb 26, 2020

Yeah, but that's not a problem except for deep dependencies. That said a single version is easier to maintain.

@LnL7 LnL7 closed this Feb 26, 2020
@LnL7 LnL7 deleted the python-msgpack branch February 26, 2020 20:28
@NilsIrl
Copy link
Member

NilsIrl commented Feb 27, 2020

you can override the python package set when calling into python. (e.g. for the vimplugin)

How would you do that?

@jonringer
Copy link
Contributor

https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#overriding-python-packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants