Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8ef3cacc332c
Choose a base ref
...
head repository: solvespace/solvespace
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fcb2757d5d18
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Feb 24, 2020

  1. Win32: Drastically reduce stack usage at startup. NFC? 

    See:
#92 (comment)

The problem was first introduced here:
dabd578

and later "fixed" here:
f324477
by setting the stack size to /STACK:33554432

Solvespace now starts up even with /STACK:554432

According to this:
https://en.cppreference.com/w/cpp/language/value_initialization
```
"2) if T is a class type with a default constructor that is neither user-provided nor deleted (that is, it may be a class with an implicitly-defined or defaulted default constructor), the object is zero-initialized and then it is default-initialized if it has a non-trivial default constructor; "
```
So removing the `{}` should leave both the `System` and `TextWindow` class instances properly initialized.
    @ruevs @whitequark
    ruevs authored and whitequark committed Feb 24, 2020
    Copy the full SHA
    fcb2757 View commit details
Loading