Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goattracker: init at 2.75 #81025

Merged
merged 1 commit into from May 22, 2020
Merged

goattracker: init at 2.75 #81025

merged 1 commit into from May 22, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Feb 25, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz fgaz mentioned this pull request Mar 5, 2020
Open
85 tasks
@OPNA2608
Copy link
Contributor

OPNA2608 commented Mar 5, 2020

There's an alternative release with stereo support, do you think you could package that one too?
https://sourceforge.net/projects/goattracker2/files/GoatTracker%202%20Stereo/

If the build process is the same, the easiest way is probably to have an optional isStereo ? false argument and adjust the pname, src and version accordingly (its version is always 1 higher than the regular release's).

OPNA2608
OPNA2608 requested changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small thing I think could be changed and a detail you should look at, otherwise looks fine to me.

pkgs/applications/audio/goattracker/default.nix Show resolved Hide resolved
pkgs/applications/audio/goattracker/default.nix Outdated Show resolved Hide resolved
@fgaz
Copy link
Member Author

fgaz commented Mar 7, 2020 •
edited

Adding the stereo version is a good Idea, I'll push the change soon

edit: done

@fgaz fgaz force-pushed the goattracker/init branch 2 times, most recently from fe5c35d to 302bf58 Compare March 7, 2020 22:39
@Lassulus
Copy link
Member

Is it possible for the stereo and non stereo version to have the same version?

@fgaz
Copy link
Member Author

fgaz commented May 22, 2020

@Lassulus are you asking if uptream will ever release goattracker and goattracker-stereo with a synced version or if we could/should sync them ourselves in the package?

@Lassulus
Copy link
Member

uhm, I haven't put much thought into it. I'm also not sure why there is a non stereo version? wouldn't the stereo version be enough?

@OPNA2608
Copy link
Contributor

OPNA2608 commented May 22, 2020 •
edited

The mono version is accurate to the actual system, as the emulated chip has no stereo controls.

@Lassulus
Copy link
Member

A thanks for the explanation.
So I guess we can keep the versions separated for now and change it when they synchronize upstream.

@Lassulus Lassulus merged commit 76ef888 into NixOS:master May 22, 2020
@fgaz fgaz deleted the goattracker/init branch May 22, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPNA2608 OPNA2608 OPNA2608 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @OPNA2608 @Lassulus