Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages: rectify URLs #81024

Merged
merged 1 commit into from
Apr 5, 2020
Merged

llvmPackages: rectify URLs #81024

merged 1 commit into from
Apr 5, 2020
+48 −48

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Feb 25, 2020 •
edited
Loading

Motivation for this change

#78482 (comment)

Things done

Updated http:// schemes to https://. Followed some moved pages.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Feb 25, 2020
@ofborg ofborg bot requested review from 7c6f434c, dtzWill and lovek323 February 25, 2020 14:07
@ofborg ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 25, 2020
@veprbl
Copy link
Member

veprbl commented Feb 25, 2020

Changes that cause a mass rebuild need to target branch "staging" instead of "master".

@ggreif
Copy link
Contributor Author

ggreif commented Feb 25, 2020 •
edited
Loading

Sure, will relocate the patch! (DONE!)

@ggreif ggreif changed the base branch from master to staging February 25, 2020 19:23
@ofborg ofborg bot added 6.topic: erlang 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion 6.topic: python 6.topic: rust 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: vim 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 25, 2020
@ggreif
Copy link
Contributor Author

ggreif commented Feb 25, 2020 •
edited
Loading

I had to cherry-pick b2ea246 from master. Will wait 'till staging has caught up with it and then rebase. This guy is not urgent at all.

UPDATE: this is now resolved.

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 6.topic: erlang 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion 6.topic: python labels Feb 25, 2020
@ofborg ofborg bot removed 6.topic: rust 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: vim 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 25, 2020
@ofborg ofborg bot requested review from edolstra, np and andir February 25, 2020 20:05
@ggreif ggreif marked this pull request as ready for review April 5, 2020 10:34
@ggreif ggreif requested a review from matthewbauer as a code owner April 5, 2020 10:34
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Apr 5, 2020
@basvandijk
Copy link
Member

Thanks Gabor!

@basvandijk basvandijk merged commit 5811d0c into NixOS:staging Apr 5, 2020
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c

@dtzWill dtzWill

@lovek323 lovek323

@edolstra edolstra

@np np

@andir andir

@matthewbauer matthewbauer

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
Staging
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ggreif @veprbl @basvandijk @rrbutani