Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages: rectify URLs #81024

Merged
merged 1 commit into from Apr 5, 2020
Merged

llvmPackages: rectify URLs #81024

merged 1 commit into from Apr 5, 2020

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Feb 25, 2020 •
edited

Motivation for this change

#78482 (comment)

Things done

Updated http:// schemes to https://. Followed some moved pages.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Feb 25, 2020

Changes that cause a mass rebuild need to target branch "staging" instead of "master".

@ggreif
Copy link
Contributor Author

ggreif commented Feb 25, 2020 •
edited

Sure, will relocate the patch! (DONE!)

@ggreif ggreif changed the base branch from master to staging February 25, 2020 19:23
@ggreif
Copy link
Contributor Author

ggreif commented Feb 25, 2020 •
edited

I had to cherry-pick b2ea246 from master. Will wait 'till staging has caught up with it and then rebase. This guy is not urgent at all.

UPDATE: this is now resolved.

@ofborg ofborg bot requested review from edolstra, np and andir February 25, 2020 20:05
@veprbl veprbl added this to WIP in Staging via automation Feb 26, 2020
@ggreif ggreif marked this pull request as ready for review April 5, 2020 10:34
@basvandijk
Copy link
Member

Thanks Gabor!

@basvandijk basvandijk merged commit 5811d0c into NixOS:staging Apr 5, 2020
Staging automation moved this from WIP to Done Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@dtzWill dtzWill Awaiting requested review from dtzWill

@lovek323 lovek323 Awaiting requested review from lovek323

@edolstra edolstra Awaiting requested review from edolstra

@np np Awaiting requested review from np

@andir andir Awaiting requested review from andir

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 0
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggreif @veprbl @basvandijk