Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] nixos/parsoid: fix service by reinstating nodePackages.parsoid #81022

Merged
merged 3 commits into from Feb 27, 2020
Merged

[20.03] nixos/parsoid: fix service by reinstating nodePackages.parsoid #81022

merged 3 commits into from Feb 27, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Feb 25, 2020 •
edited

Backport of #80998. The node2nix run resulted in quite a bit of updated node packages. Should I split this in separate commit?(done) Try to pick out only changes needed for adding parsoid?

cc @Mic92

Fixes services.parsoid (MediaWiki VisualEditor backend) which does not work at least since 2b8cde0. Also enables systemd sandboxing, namely DynamicUser instead of using nobody which is a bad thing according to #55370.

Motivation for this change

The nixos/parsoid module is currently broken because it referes to nonexistent package:

error: attribute 'parsoid-git://github.com/abbradar/parsoid#stable' missing, at /nix/store/kyf94wnik8sx13csarz8cjajgw1jaswb-source/nixos/modules/services/misc/parsoid.nix:9:13
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Enteee
Copy link
Contributor

Enteee commented Feb 26, 2020

In #80998 @Mic92 commented:

However its a bit tricky because the node-package set needs to be regenerated for 20.03.

As I understand it this just involves running node2nix. Am I missing any hidden implications by doing this, or what's tricky about that?

@Mic92
Copy link
Member

Mic92 commented Feb 27, 2020

In #80998 @Mic92 commented:

However its a bit tricky because the node-package set needs to be regenerated for 20.03.

As I understand it this just involves running node2nix. Am I missing any hidden implications by doing this, or what's tricky about that?

The tricky part is that we actually want to stabilize 20.03 and only backport necessary updates, while updating the whole set may break packages.

@mmilata
nodePackages.parsoid: init at 0.11.0
e83edde 
(not-really-cherry-picked from commit 9264a0f)
@mmilata
nixos/parsoid: fix package name
c83c446 
Original package was removed in 2b8cde0.

(cherry picked from commit 3b27f4d)
@mmilata
nixos/parsoid: enable systemd sandboxing
a65ea62 
(cherry picked from commit 9b0a957)
@mmilata
Copy link
Member Author

mmilata commented Feb 27, 2020

Updated the PR to not update any packages in nodePackages, result is that packages are only added to the set. Parsoid seems to work and I believe this shouldn't cause any existing package to break? Please take a look!

If this is not the way to go I see two alternatives:

  • make the parsoid build independent of nodePackages (like, here)
  • drop the NixOS module in 20.03 as no module is probably better than broken one.

@Mic92 Mic92 merged commit 287e7f9 into NixOS:release-20.03 Feb 27, 2020
@Mic92
Copy link
Member

Mic92 commented Feb 27, 2020

@mmilata thanks for the extra effort to backport this!

@mmilata mmilata deleted the parsoid-20.03 branch February 27, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmilata @Enteee @Mic92