New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipmitool: migrate to openssl 1.1 #80987
Conversation
This adds a patch from debian to switch ipmitool to openssl 1.1. Upstream seems to already carry a version of this but that is yet to be part of a release.
Also, while at it, can you replace the |
It seems like you care about darwin here, so what about adding it into |
url = "https://sources.debian.org/data/main/i/ipmitool/1.8.18-6/debian/patches/0120-openssl1.1.patch"; | ||
sha256 = "1xvsjxb782lzy72bnqqnsk3r5h4zl3na95s4pqn2qg7cic2mnbfk"; | ||
}) | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: this doesn't seem like dynamically generated patch, so I expect fetchurl
should suffice, but I see no problem with using fetchpatch
anyway. EDIT: this referred to the debian one – GitHub now shows the comment under the other one which is dynamically generated.
@GrahamcOfBorg eval |
I can't verify this works on Darwin, as I don't have the hardware around - I just realized the mentioned substitution became a no-op. |
* remove no-op substitution of s6_addr16 -> s6_addr This string doesn't exist anymore in that file. * clean up configureFlags
Motivation for this change
This adds a patch from debian to switch ipmitool to openssl 1.1. Upstream seems to already carry a version of this but that is yet to be part of a release.
If this is accepted we should backport to 20.03.
cc #80746
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)