vde2: fix build with latest openssl #80986
Conversation
There was a problem hiding this comment.
The project seems to be using wolfssl nowadays: virtualsquare/vde-2@8599321
This hasn't landed yet but might as well pick that patch from upstream (if it applies) instead of another downstream patch?
Nitpick: While we touch this the new home of the project is https://github.com/virtualsquare/vde-2. Can you update that?
|
Just noticed that if we go with the upstream patch (not really biased at this time) we might want to pick virtualsquare/vde-2#11 as well. |
@andir I'm not really familiar with this package, but I do see it being used in the actual python testing driver. Those sound like major changes, not really great for a stable release even if we're still in BETA.
I always fix the nits 👍 |
|
On 15:35 24.02.20, worldofpeace wrote:
> The project seems to be using wolfssl nowadays:
> ***@***.***
>
> This hasn't landed yet but might as well pick that patch from
> upstream (if it applies) instead of another downstream patch?
@andir I'm not really familiar with this package, but I do see it
being used in the actual python testing driver. Those sound like major
changes, not really great for a stable release even if we're still in
BETA.
I just thought the upstream patch my be as good as any abitrary
downstream distro patch. We can also use your proposed approach instead.
I really have no hard feelings either way.
|
|
Let's merge this with archlinux' patches for now. Once the project finished moving to wolfssl, we can do so too. |
Motivation for this change
#80746
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)