nixos/parsoid: fix service by reinstating nodePackages.parsoid #80998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original package was removed in 2b8cde0.
Mic92
reviewed
Feb 25, 2020
| @@ -98,8 +98,29 @@ in | |||
| wantedBy = [ "multi-user.target" ]; | |||
| after = [ "network.target" ]; | |||
| serviceConfig = { | |||
| User = "nobody"; | |||
There was a problem hiding this comment.
Yeah, nobody should be never used actually for services.
|
That might be a good candidate for backporting... However its a bit tricky because the node-package set needs to be regenerated for 20.03. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
services.parsoid(MediaWiki VisualEditor backend) which does not work at least since 2b8cde0. Also enables systemd sandboxing, namelyDynamicUserwhich fixes #55370.Motivation for this change
The nixos/parsoid module is currently broken because it referes to nonexistent package:
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @abbradar @aanderse @Mic92