Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb: fix ssl by upgrading 3.4.22 -> 3.4.24 #81027

Closed
wants to merge 24 commits into from

Conversation

tricktron
Copy link
Member

Motivation for this change

The compilation of version 3.4.22 was failing with an ssl error on darwin. Reverting the ssl fix commit and upgrading the version to 3.4.24 fixes the ssl error.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jarjee and others added 24 commits February 25, 2020 15:16
fix: Adding libtool to allow darwin compiles

Libtool seems to be required for mongodb to compile on darwin.

fix: Marking MongoDB as broken on aarch64

fix: Adding libtools to the pkg imports

Update mongodb to 4.0.4
I'm having some issues with the final scons output, the install doesn't
seem to work and I'm not entirely sure why.
By returning true, we prevent the build from failing.
Now has tests for 3.4, 3.6, 4.0. Has some duplication, but it appears to
work on my machine.
One of the asio patches shouldn't be applied to 3.4, this resolves that
issue
This reverts commit be023808c59d3a43a5fd0059b7191cedbcda5bcc.
Reverts previous ssl fix commit and updates the mongodb version which fixes the ssl compile problem on darwin.
@tricktron
Copy link
Member Author

I reverted the ssl fix commit and updated the version from 3.4.22 -> 3.4.24 which fixes the ssl error. So 3.4.24 compiles now on darwin. Lastly, I also rebased the branch on master to fix merge conflict.

I actually didn't want to create a new pull request. How could I have added my commits to the existing pull request #40082?

@tricktron tricktron mentioned this pull request Feb 26, 2020
8 tasks
@bachp
Copy link
Member

bachp commented Feb 29, 2020

I think this would make mongodb work again after #80746 was merged.

Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working with unifi controller.

@tricktron
Copy link
Member Author

I think this would make mongodb work again after #80746 was merged.

Exactly. Would be nice to have MongoDB working again in Nixpkgs.

Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Including patches in the Nixpkgs tree is the less prefered way. Is there any possibility you could either upstream these patches or fetchpatch them from a source like a PR to upstream? If none of this is possible please document in the code where you got the patches from, e.g. wether you composed them yourself or where you found them.

Also could you squash your changes into a single commit? At the moment it would be sufficient to have these changes in one commit in Nixpkgs.

@bachp
Copy link
Member

bachp commented Mar 6, 2020

@erictapen @tricktron as this is based on the work of @jarjee in #40082 I think it would make sense to create two commits, so each author is credited appropriately.

@erictapen
Copy link
Member

@bachp For that one can include Co-Authored-By: jarjee <jarjee@users.noreply.github.com> in the commit message. This is registered as a commit with two or more authors, e.g. 4ea8f05.

@tricktron
Copy link
Member Author

As @jarjee cherrypicked my fixing commit into his pull request #40082 I am going to close this one.

@erictapen Thanks for your review. Could you address your questions directly at @jarjee in #40082? @jarjee did most of the work and may be able to answer these questions. I just fixed the last blocking ssl error on darwin for v3.4.

@tricktron tricktron closed this Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants