New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mongodb: fix ssl by upgrading 3.4.22 -> 3.4.24 #81027
Conversation
fix: Adding libtool to allow darwin compiles Libtool seems to be required for mongodb to compile on darwin. fix: Marking MongoDB as broken on aarch64 fix: Adding libtools to the pkg imports Update mongodb to 4.0.4
I'm having some issues with the final scons output, the install doesn't seem to work and I'm not entirely sure why.
By returning true, we prevent the build from failing.
Now has tests for 3.4, 3.6, 4.0. Has some duplication, but it appears to work on my machine.
One of the asio patches shouldn't be applied to 3.4, this resolves that issue
This reverts commit be023808c59d3a43a5fd0059b7191cedbcda5bcc.
Reverts previous ssl fix commit and updates the mongodb version which fixes the ssl compile problem on darwin.
I reverted the ssl fix commit and updated the version from 3.4.22 -> 3.4.24 which fixes the ssl error. So 3.4.24 compiles now on darwin. Lastly, I also rebased the branch on master to fix merge conflict. I actually didn't want to create a new pull request. How could I have added my commits to the existing pull request #40082? |
I think this would make mongodb work again after #80746 was merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working with unifi controller.
Exactly. Would be nice to have MongoDB working again in Nixpkgs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Including patches in the Nixpkgs tree is the less prefered way. Is there any possibility you could either upstream these patches or fetchpatch
them from a source like a PR to upstream? If none of this is possible please document in the code where you got the patches from, e.g. wether you composed them yourself or where you found them.
Also could you squash your changes into a single commit? At the moment it would be sufficient to have these changes in one commit in Nixpkgs.
@erictapen @tricktron as this is based on the work of @jarjee in #40082 I think it would make sense to create two commits, so each author is credited appropriately. |
As @jarjee cherrypicked my fixing commit into his pull request #40082 I am going to close this one. @erictapen Thanks for your review. Could you address your questions directly at @jarjee in #40082? @jarjee did most of the work and may be able to answer these questions. I just fixed the last blocking ssl error on darwin for |
Motivation for this change
The compilation of version 3.4.22 was failing with an ssl error on darwin. Reverting the ssl fix commit and upgrading the version to 3.4.24 fixes the ssl error.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)