mate.mate-themes: 3.22.20 -> 3.22.21 #80925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romildo
changed the title
jonringer
approved these changes
Feb 24, 2020
worldofpeace
suggested changes
Feb 24, 2020
There was a problem hiding this comment.
I see there's some icon themes here
ContrastHigh mate mate-black
one of whichContrastHigh you generate an icon cache for.
You'll need to set dontDropIconThemeCache = true; so the gtk setup hook doesn't remove it.
Should we generate icon cache's for the other icon themes as well?
|
|
||
| src = fetchurl { | ||
| url = "https://pub.mate-desktop.org/releases/themes/${stdenv.lib.versions.majorMinor version}/${pname}-${version}.tar.xz"; | ||
| sha256 = "0c3dhf8p9nc2maky4g9xr04iil9wwbdkmhpzynlc6lfg4ksqq2bx"; | ||
| sha256 = "051g2vq817g84yrqzf7hjcqr4xrghnw1rprjd6jf5mhhzmwcas6n"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig intltool gtk3 ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ pkgconfig intltool gtk3 ]; | |
| nativeBuildInputs = [ pkgconfig gettext gtk3 ]; |
migrate from intltool to gettext https://github.com/mate-desktop/mate-themes/releases/tag/v3.22.21
Set dontDropIconThemeCache so the gtk setup hook doesn't remove the icon cache.
Done.
I suppose no, because they are cursors only. |
worldofpeace
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to version 3.22.21
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)