nixosTests.networking: disable virtual test with networkd #81013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andir
reviewed
Feb 25, 2020
| testScript = '' | ||
| # The test is disabled for systemd-networkd. | ||
| # See the commit message of a3a441c. | ||
| testScript = optionalString (!networkd) '' |
There was a problem hiding this comment.
This sounds like the wrong place to do this. Shouldn't that be done in line 449 and just set to null in case of networkd?
There was a problem hiding this comment.
I tried setting the attrset to null or { } but it doesn't work.
There was a problem hiding this comment.
ping. I'd like to fix this before the final release of 20.03
|
Can you take a look at #85170, which keeps running the test with networkd? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ZHF: #80379
Things done
nixosTests.networking.networkd.virtualnixosTests.networking.scripted.virtualI don't know how to disable the build of a test. This will effectively silence the failure but the test will be built anyway, which is probably misleading.