Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anydesk: add update script #80979

Closed
wants to merge 1 commit into from
Closed

anydesk: add update script #80979

wants to merge 1 commit into from

Conversation

mkg20001
Copy link
Member

Motivation for this change

Make it auto-update

Things done

Don't know if this is the right way to do things. Also doesn't fully work yet, just the standalone script works if executed in the right folder.

Having some kindof wrapper / wrapper function would be cool.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
Copy link
Contributor

Make it auto-update

This won't happen automatically, see https://discourse.nixos.org/t/questions-regarding-passthru-updatescript/7315 .

If you are still interested in this, you should also read https://nixos.org/nixpkgs/manual/#var-passthru-updateScript .

Having some kindof wrapper / wrapper function would be cool.

Use a nix-shell shebang, as demonstrated in the example of the manual.

@stale
Copy link

stale bot commented Nov 20, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 20, 2020
@SuperSandro2000
Copy link
Member

@mkg20001 friendly ping

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 23, 2020
@ajs124
Copy link
Member

ajs124 commented Feb 3, 2021

@r-ryantm already seems to update this, see #111146

@ryantm
Copy link
Member

ryantm commented Feb 3, 2021

r-ryantm already seems to update this

Note it fails to update all the platforms.

@ajs124
Copy link
Member

ajs124 commented Feb 3, 2021

There is only one platform left.

otavio added a commit to otavio/nixpkgs that referenced this pull request Feb 6, 2021
@otavio
anydesk: Add auto-update support
83e1c6c 
This allow auto-update of the package and reduce maintenance burden.

Refs: NixOS#80979
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
@otavio otavio mentioned this pull request Feb 6, 2021
Merged
10 tasks
@mkg20001
Copy link
Member Author

I suppose I can close it then. If anyone still thinks this script is necessary, just comment.

@mkg20001 mkg20001 closed this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkg20001 @doronbehar @SuperSandro2000 @ajs124 @ryantm