Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Length callback for vehicles doesn't accept switches #90

Closed
spnda opened this issue Feb 24, 2020 · 1 comment
Closed

Length callback for vehicles doesn't accept switches #90

spnda opened this issue Feb 24, 2020 · 1 comment

Comments

@spnda
Copy link
Contributor

spnda commented Feb 24, 2020 •
edited

So I've built the master branch of NML and now it seems that all vehicles do not accept switches for the length Action3 callback.
My source for the code can be found here: https://github.com/spnda/VGF-Set
(I use a python script to put all pnml files together, for the file in question look at src/trams/Type-P.pnml.

If length is given a switch, nmlc throws an error. However there's no error thrown when there is just a value passed.

length: 5;

The error I receive:

 nmlc ERROR: "src/trams/Type-P.pnml", line 60: Unexpected identifier encountered: 'switch_type_p_length'
Included from: "vgf.pnml", line 1
Included from: "src/trams/Type-O.pnml", line 59
Included from: "vgf.pnml", line 1
Included from: "src/trams/Type-KEE.pnml", line 49
Included from: "vgf.pnml", line 2
Included from: "src/template.pnml", line 29
Included from: "vgf.pnml", line 1
Included from: "src/sort.pnml", line 15
Included from: "vgf.pnml", line 1
Included from: "src/header.pnml", line 9
Included from: "vgf.pnml", line 1
Included from: "src/checks.pnml", line 8
Included from: "vgf.pnml", line 1
Included from: "src/cargotable.pnml", line 6
Included from: "vgf.pnml", line 1
Included from: "src/basecost.pnml", line 8
Included from: "vgf.pnml", line 1
@TrueBrain
Copy link
Member

e9429c8#diff-3badf455a77aea8a647705e4c898078cR182

Introduced this error.

glx22 added a commit to glx22/nml that referenced this issue Feb 24, 2020
@glx22
Fix OpenTTD#90, e9429c8: Procedure calls checks were too strict
a13e776
glx22 added a commit to glx22/nml that referenced this issue Feb 25, 2020
@glx22
Fix OpenTTD#90, e9429c8: Generated procedure calls where not properly…
a3e02cf 
… marked
glx22 added a commit to glx22/nml that referenced this issue Feb 25, 2020
@glx22
Add: Regression test case for OpenTTD#90
5095fc9
planetmaker pushed a commit that referenced this issue Mar 2, 2020
@glx22 @planetmaker
Add: Regression test case for #90
660722b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TrueBrain @spnda