Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam.chrootenv: add udev #81003

Merged
merged 1 commit into from Feb 26, 2020
Merged

steam.chrootenv: add udev #81003

merged 1 commit into from Feb 26, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 25, 2020 •
edited

Motivation for this change

to solve https://discourse.nixos.org/t/mismatched-behavior-between-custom-fhsuserenv-and-steam-lutris-fhsuserenv/6020

Needed by Shadow of the Tomb Raider

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
steam.chrootenv: add udev
ef0159d 
Needed by Shadow of the Tomb Raider
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/mismatched-behavior-between-custom-fhsuserenv-and-steam-lutris-fhsuserenv/6020/2

@jonringer
Copy link
Contributor Author

3MB closure difference

killercup
killercup approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this works!

@jonringer
Copy link
Contributor Author 

[30 built, 488 copied (3110.6 MiB), 835.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81003
7 package built:
kodiPlugins.steam-launcher linux-steam-integration lutris steam steam-run steam-run-native steamcmd

@jonringer jonringer merged commit 9d4aab7 into NixOS:master Feb 26, 2020
@jonringer jonringer deleted the steam-udev branch February 26, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killercup killercup killercup approved these changes

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @nixos-discourse @killercup