Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 4f7484f03895
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 1b5e9c48185b
Choose a head ref
  • 3 commits
  • 1 file changed
  • 2 contributors

Commits on Feb 2, 2020

  1. chatterino2: fix install on macOS 

    On Darwin/macOS, chatterino2's install phase copies no files into the
output. `make install` does not copy chatterino2.app. Copy the .app
manually, fixing the installation.

With this patch, chatterino2 almost works on macOS. Issue #42893
applies, so to make chatterino2 work, you must install qtbase in your
environment. For example:

    $ nix-env -iA nixpkgs.qt5.qtbase
    $ open ~/.nix-profile/Applications/chatterino.app
    @strager
    strager committed Feb 2, 2020
    Copy the full SHA
    cdd1c21 View commit details
    Browse the repository at this point in the history

  2. chatterino2: fix: Could not find the Qt platform plugin "cocoa" in "" 

    wrapQtAppsHook ignores Mach-O binaries [1]. Additionally, wrapQtAppsHook
doesn't look inside $out/Applications [2], which is where chatterino2 is
installed. This means chatterino2 for Darwin/macOS is not wrapped
properly, causing the following error when launched:

> qt.qpa.plugin: Could not find the Qt platform plugin "cocoa" in ""
>
> This application failed to start because no Qt platform plugin could
> be initialized. Reinstalling the application may fix this problem.

On macOS, explicitly wrap chatterino2's executable.

[1] pkgs/development/libraries/qt-5/hooks/wrap-qt-apps-hook.sh line 85
[2] pkgs/development/libraries/qt-5/hooks/wrap-qt-apps-hook.sh line 76
    @strager
    strager committed Feb 2, 2020
    Copy the full SHA
    1221a6b View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Merge pull request #79067 from strager/chatterino2-darwin 

    chatterino2: fix install on macOS
    @LnL7
    LnL7 committed Feb 25, 2020
    Copy the full SHA
    1b5e9c4 View commit details
    Browse the repository at this point in the history