Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresqlPackages.postgis: 3.0.0 -> 3.0.1 #81001

Merged
merged 1 commit into from Feb 25, 2020
Merged

postgresqlPackages.postgis: 3.0.0 -> 3.0.1 #81001

merged 1 commit into from Feb 25, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 25, 2020

Motivation for this change

Release notes: https://postgis.net/2020/02/20/postgis-3.0.1/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

lsix
lsix approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review happy:

$ nix-review pr 81001
[…]
https://github.com/NixOS/nixpkgs/pull/81001
1 package built:
postgresqlPackages.postgis

$ nix-shell /home/lsix/.cache/nixpkgs-review/pr-81001/shell.nix

Test happy:

$ nix-build nixos/tests/postgis.nix
[…]
test script finished in 35.47s
cleaning up
killing master (pid 6)
(0.00 seconds)
/nix/store/iz6j0ra1xiiiparwa21py8yrdzy0y6zp-vm-test-run-postgis

I however note that we are late on nearly all recommended dependency versions:

Best served with PostgreSQL 12.2, GEOS 3.8.0, SFCGAL 1.3.7, GDAL 3.0.4, PROJ 6.3.1, protobuf-c 1.3.3, json-c 0.13.1.

We should have a look there.

@marsam marsam merged commit 6ee4ac1 into NixOS:master Feb 25, 2020
@marsam marsam deleted the update-postgis branch February 25, 2020 13:06
@lsix
Copy link
Member

lsix commented Feb 25, 2020

@marsam do you handle backporting ?

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 26, 2020
@marsam @dtzWill
Merge pull request NixOS#81001 from marsam/update-postgis
ea612cf 
postgresqlPackages.postgis: 3.0.0 -> 3.0.1

(cherry picked from commit 6ee4ac1)
@marsam
Copy link
Contributor Author

marsam commented Feb 28, 2020

yes, sorry for the delay
backported to 20.03 in 89536cd763c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @lsix