python27Packages.feedgenerator: 1.9 -> 1.9.1 #80946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsix
requested changes
Feb 24, 2020
There was a problem hiding this comment.
$ nix-review pr 80946
[…]
https://github.com/NixOS/nixpkgs/pull/80946
2 package failed to build:
python37Packages.pelican python38Packages.pelican
3 package built:
python27Packages.feedgenerator python37Packages.feedgenerator python38Packages.feedgenerator
pelican is also broken on master (and on release-20.03), this update does not change it.
Homepage should however be updated.
| @@ -17,7 +17,7 @@ buildPythonPackage rec { | |||
|
|
|||
| meta = with stdenv.lib; { | |||
| description = "Standalone version of django.utils.feedgenerator, compatible with Py3k"; | |||
| homepage = https://github.com/dmdm/feedgenerator-py3k.git; | |||
| homepage = "https://github.com/dmdm/feedgenerator-py3k.git"; | |||
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/dmdm/feedgenerator-py3k.git"; | |
| homepage = "https://github.com/getpelican/feedgeneratorgit"; |
According to pypi (https://pypi.org/project/feedgenerator/), this should be https://github.com/getpelican/feedgenerator
| @@ -17,7 +17,7 @@ buildPythonPackage rec { | |||
|
|
|||
| meta = with stdenv.lib; { | |||
| description = "Standalone version of django.utils.feedgenerator, compatible with Py3k"; | |||
| homepage = https://github.com/dmdm/feedgenerator-py3k.git; | |||
| homepage = "https://github.com/dmdm/feedgenerator-py3k.git"; | |||
| maintainers = with maintainers; [ ]; | |||
There was a problem hiding this comment.
License information should probably be added.
https://github.com/getpelican/feedgenerator/blob/master/LICENSE
|
going to let the bot recreate PR, it can now correctly quote URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python2.7-feedgenerator/versions.
meta.description for python27Packages.feedgenerator is: "Standalone version of django.utils.feedgenerator, compatible with Py3k"
meta.homepage for python27Packages.feedgenerator is: "https://github.com/dmdm/feedgenerator-py3k.git"
Checks done (click to expand)
built on NixOS
Warning: a test defined in
passthru.testsdid not pass0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 1.9.1 with grep in /nix/store/ma9m0zm1l9247qd3j3f5m66cmx3f9sss-python2.7-feedgenerator-1.9.1
directory tree listing: https://gist.github.com/0c2767859a7dc99c22c758079dc0163e
du listing: https://gist.github.com/7c7631d1ac676d9b4234df643385c33e
Rebuild report (if merged into master) (click to expand)
20 total rebuild path(s)
5 package rebuild(s)
5 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
5 x86_64-darwin rebuild(s)
5 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
python27Packages.feedgenerator
python37Packages.feedgenerator
python37Packages.pelican
python38Packages.feedgenerator
python38Packages.pelican
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries: