Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liblinear: use absolute install name on Darwin #81015

Merged
merged 1 commit into from Feb 25, 2020
Merged

liblinear: use absolute install name on Darwin #81015

merged 1 commit into from Feb 25, 2020

Conversation

thefloweringash
Copy link
Member

nixpkgs prefers absolute install names. Replace the manually specified
relative install name with the standard hook.

Motivation for this change

Fixing nmap on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thefloweringash
liblinear: use absolute install name on Darwin
1eaa748 
nixpkgs prefers absolute install names. Replace the manually specified
relative install name with the standard hook.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 25, 2020
@ofborg ofborg bot requested a review from danieldk February 25, 2020 12:07
danieldk
danieldk approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using absolute names is definitely better. Tested build on Catalina as well.

LGTM

@veprbl
Copy link
Member

veprbl commented Feb 25, 2020

@GrahamcOfBorg build nmap

@veprbl veprbl merged commit 1a73b69 into NixOS:master Feb 25, 2020
@thefloweringash thefloweringash deleted the liblinear-install-name branch February 25, 2020 15:32
veprbl pushed a commit that referenced this pull request Feb 25, 2020
@thefloweringash @veprbl
liblinear: use absolute install name on Darwin (#81015)
69b2c24 
nixpkgs prefers absolute install names. Replace the manually specified
relative install name with the standard hook.

(cherry picked from commit 1a73b69)

cc #81015
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Feb 25, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 26, 2020
@thefloweringash @dtzWill
liblinear: use absolute install name on Darwin (NixOS#81015)
8eaeff0 
nixpkgs prefers absolute install names. Replace the manually specified
relative install name with the standard hook.

(cherry picked from commit 1a73b69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @veprbl @danieldk