Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add J-Link binary package for embedded debugging #80990

Closed
wants to merge 1 commit into from
Closed

Add J-Link binary package for embedded debugging #80990

wants to merge 1 commit into from

Conversation

reardencode
Copy link
Contributor

Motivation for this change

J-Link is a common tool used in embedded development. It'd be great to be able to use it on NixOS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented Mar 12, 2020

I rebased your commit on top of the master and fixed issues I've found.

You might want to pull this into your master branch overwriting the current PR: prusnak@67c5c1b

@liff
Copy link
Contributor

liff commented Apr 27, 2020

Tried building this on nixos-unstable but it fails with:

searching for dependencies of /nix/store/q7qpcqzzm4i2ls2jhyh10siagi2i7w06-jlink-V662d/JLink/libjlinkarm_x86.so.6.62.4
searching for dependencies of /nix/store/q7qpcqzzm4i2ls2jhyh10siagi2i7w06-jlink-V662d/JLink/libjlinkarm.so.6.62.4
  libudev.so.1 -> not found!
  libstdc++.so.6 -> found: /nix/store/n587ax9k9rc5cxm66aiibsss60pqk6b4-gcc-9.3.0-lib/lib/../lib64/libstdc++.so.6

Adding udev to buildInputs fixes it for me though.

liff
liff reviewed Apr 27, 2020
View reviewed changes
pkgs/development/tools/jlink/default.nix
homepage = "https://www.segger.com/downloads/jlink";
description = "SEGGER J-Link";
license = licenses.unfree;
platforms = platforms.linux;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this list the platforms from architecture? That is: platforms = [ "x86_64-linux" "i686-linux" "armv7l-linux" ].

@reardencode
jlink: init at V662d
1da0ca7 
J-Link binary package for embedded debugging
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixpkgs-adding-ld-library-path/11573/1

@mtetreault
Copy link

I would really love to have jlink supported in master. Is there anything I could do to help bringing this to master?

@evils evils mentioned this pull request May 4, 2021
Closed
10 tasks
FlorianFranzen
FlorianFranzen suggested changes May 5, 2021
View reviewed changes
pkgs/development/tools/jlink/default.nix
sha256 = {
x86_64-linux = "0vc7x6kjs92p6qdsn2lazmvlw7npz1z7r9ipj85wd123m7hgwnmg";
i686-linux = "01qm56jyac3mzjny1z5lynik8y4hqrfq93n8119mvj6d4xiknv8y";
armv7l-linux = "03l2zkfjw7z6j6nsdw6j4nxxzh8mgby8qrc179qjcajbdr3hmbr7";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misses the aarch64-linux release, which has much better binary cache support.

@FlorianFranzen
Copy link
Contributor

Superseded by and incorporated into by #121601.

FlorianFranzen
FlorianFranzen reviewed May 5, 2021
View reviewed changes
pkgs/development/tools/jlink/default.nix

dontConfigure = true;
dontBuild = true;
dontStrip = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not include the dontStrip in the new version. Is that something we need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liff liff liff left review comments

@FlorianFranzen FlorianFranzen FlorianFranzen requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@reardencode @prusnak @liff @nixos-discourse @mtetreault @FlorianFranzen @ryantm