gdb: Fix abort w/NIX_DEBUG_INFO_DIRS patch #80929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orivej
reviewed
Feb 24, 2020
|
Thanks for bringing this up. I’ll go update the 9.1 upgrade ASAP. |
The current gdb patch to support NIX_DEBUG_INFO_DIRS fails if the user attempts to change the debug file directory to a value other than the default. For instance: (gdb) set debug-file-directory /run/booted-system/sw/lib/debug results in: munmap_chunk(): invalid pointer Aborted (core dumped) To fix this issue, the debug_file_directory is allocated with xstrdup so that a subsequent call to xfree will succeed.
tollb
force-pushed
the
fix/gdb-debug-file-directory
branch
from
d89c7ad
to
ba10646
Compare
lsix
approved these changes
Feb 24, 2020
|
Once merged, I’ll rebase the 9.1 upgrade on top of it since it might conflict. |
Thanks. I really appreciate your help with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current gdb patch to support NIX_DEBUG_INFO_DIRS fails if
the user attempts to change the debug file directory to a
value other than the default. For instance:
(gdb) set debug-file-directory /run/booted-system/sw/lib/debug
results in:
munmap_chunk(): invalid pointer
Aborted (core dumped)
To fix this issue, the debug_file_directory is allocated
with xstrdup so that a subsequent call to xfree will succeed.
NOTE: As a workaround, unset NIX_DEBUG_INFO_DIRS before running gdb.
This patch was tested on gdb 8.3.1. If merged, it can hopefully be included in 20.03. The gdb 9.1 upgrade in #79711 also appears to have the same issue. @lsix
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)