Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: 3.1.0 -> 3.1.1 #80967

Merged
merged 1 commit into from Feb 24, 2020
Merged

helm: 3.1.0 -> 3.1.1 #80967

merged 1 commit into from Feb 24, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 24, 2020 •
edited

Motivation for this change

https://github.com/helm/helm/releases/tag/v3.1.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

rlupton20
rlupton20 approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@rlupton20 rlupton20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlewo nlewo merged commit fd920aa into NixOS:master Feb 24, 2020
@Frostman Frostman deleted the helm-3.1.1 branch February 24, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@rlupton20 rlupton20 rlupton20 approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@edude03 edude03 Awaiting requested review from edude03

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Frostman @saschagrunert @rlupton20 @nlewo