Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadbeef: 1.8.0 -> 1.8.2 #81010

Merged
merged 2 commits into from Mar 3, 2020
Merged

deadbeef: 1.8.0 -> 1.8.2 #81010

merged 2 commits into from Mar 3, 2020

Conversation

ccellado
Copy link
Contributor

@ccellado ccellado commented Feb 25, 2020

Motivation for this change

New release : https://github.com/DeaDBeeF-Player/deadbeef/releases/tag/1.8.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor Author

@ccellado ccellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed comment

@nlewo
Copy link
Member

nlewo commented Mar 3, 2020

@GrahamcOfBorg build deadbeef

@nlewo nlewo merged commit 0da63e8 into NixOS:master Mar 3, 2020
jtojnar added a commit that referenced this pull request Mar 31, 2020
This was forgotten in #81010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants