Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shortwave: init at 1.0.1 #83163

Merged
merged 1 commit into from Apr 8, 2020
Merged

shortwave: init at 1.0.1 #83163

merged 1 commit into from Apr 8, 2020

Conversation

lasandell
Copy link
Contributor

Motivation for this change

Add shortwave as it is intended to replace gradio. More info here: https://blogs.gnome.org/haeckerfelix/2020/03/15/shortwave-1-0-0/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Emantor
Copy link
Member

Emantor commented Apr 6, 2020

Fails to build with a glib related error:

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/phoenix/.cache/nixpkgs-review/pr-83163/build.nix
builder for '/nix/store/kpb32mb19qdixpmynmj8rsvmx7qq38y8-shortwave-1.0.1.drv' failed with exit code 2; last 10 log lines:
      state, ifile, source_dirs, dependencies)
    File "/nix/store/9z5fg8ia4lr10nqglk3jlwyd7xcqadzk-meson-0.53.2/lib/python3.7/site-packages/mesonbuild/modules/gnome.py", line 229, in _get_gresource_dependencies
      pc, stdout, stderr = Popen_safe(cmd, cwd=state.environment.get_source_dir())
    File "/nix/store/9z5fg8ia4lr10nqglk3jlwyd7xcqadzk-meson-0.53.2/lib/python3.7/site-packages/mesonbuild/mesonlib.py", line 1090, in Popen_safe
      stdout=stdout, stderr=stderr, **kwargs)
    File "/nix/store/vs4vj1yzqj1bkcqkf3b6sxm6jfy1gb4j-python3-3.7.7/lib/python3.7/subprocess.py", line 800, in __init__
      restore_signals, start_new_session)
    File "/nix/store/vs4vj1yzqj1bkcqkf3b6sxm6jfy1gb4j-python3-3.7.7/lib/python3.7/subprocess.py", line 1551, in _execute_child
      raise child_exception_type(errno_num, err_msg, err_filename)
  FileNotFoundError: [Errno 2] No such file or directory: 'glib-compile-resources': 'glib-compile-resources'
cannot build derivation '/nix/store/s9cqj30k1hdgw34pgl2kylvk9y77pyff-env.drv': 1 dependencies couldn't be built
[2 built (1 failed), 157 copied (537.2 MiB), 132.2 MiB DL]
error: build of '/nix/store/s9cqj30k1hdgw34pgl2kylvk9y77pyff-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/83163
1 package failed to build:
shortwave

@lasandell
Copy link
Contributor Author

Thanks for the test! I just force pushed a new commit that moves glib from buildInputs to nativeBuildInputs. This seems to resolve the issue.

jtojnar
jtojnar reviewed Apr 7, 2020
View reviewed changes
pkgs/applications/audio/shortwave/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/shortwave/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/shortwave/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/shortwave/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/shortwave/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/shortwave/default.nix Outdated Show resolved Hide resolved
@lasandell
Copy link
Contributor Author

@jtojnar Thanks for the review! I forced push a new commit formatted with nixpkgs-fmt and your other suggested changes.

@lasandell
Copy link
Contributor Author

Just forced pushed another commit with that formatting change.

@jtojnar jtojnar merged commit 044a1f0 into NixOS:master Apr 8, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Apr 8, 2020

Great job. Thanks.

@lasandell lasandell deleted the shortwave-1.0.1 branch February 15, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lasandell @Emantor @jtojnar