Use the stopsign as icon for timeouts and exceeded log-limits #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I browse failed builds in a jobset-eval on Hydra, I regularly mistake actual build-failures with temporary issues like timeouts (that probably disappear at the next eval). To prevent this kind of issue, I figured that using the stopsign-svg for builds with timeouts or exceeded log-limits is a reasonable choice for the following reasons: * A user can now distinguish between actual build-errors (like compilation-failures or oversized outputs) and (usually) temporary issues (like a bloated log or a timeout). * The stopsign is also used for aborted jobs that are shown in a different tab and can't be confused with timeouts for that reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I browse failed builds in a jobset-eval on Hydra, I regularly
mistake actual build-failures with temporary issues like timeouts (that
probably disappear at the next eval).
To prevent this kind of issue, I figured that using the stopsign-svg for
builds with timeouts or exceeded log-limits is a reasonable choice for
the following reasons:
A user can now distinguish between actual build-errors (like
compilation-failures or oversized outputs) and (usually) temporary issues
(like a bloated log or a timeout).
The stopsign is also used for aborted jobs that are shown in a
different tab and can't be confused with timeouts for that reason.