Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netease-cloud-music: do not set QT_AUTO_SCREEN_SCALE_FACTOR #83117

Merged
merged 1 commit into from Mar 22, 2020
Merged

netease-cloud-music: do not set QT_AUTO_SCREEN_SCALE_FACTOR #83117

merged 1 commit into from Mar 22, 2020

Conversation

Ninlives
Copy link
Contributor

Motivation for this change

It is not a good idea to set QT_AUTO_SCREEN_SCALE_FACTOR in packages. Users may want to cusomize the scale (i.e. set QT_SCALE in the session) and set scales in package will lead to unexpected results.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ninlives
Copy link
Contributor Author

@GrahamcOfBorg build netease-cloud-music

JeffLabonte
JeffLabonte approved these changes Mar 22, 2020
View reviewed changes
Copy link
Contributor

@JeffLabonte JeffLabonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds, run well on 1920x1080:

https://i.imgur.com/CQXl8qR.png

@matthewbauer matthewbauer merged commit e7dc153 into NixOS:master Mar 22, 2020
@Ninlives Ninlives deleted the netease-music-fix branch March 24, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffLabonte JeffLabonte JeffLabonte approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ninlives @JeffLabonte @matthewbauer