alsa-lib: 1.1.9 -> 1.2.2 and new alsa conf packages #83155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should probably target the staging branch. |
Emantor
approved these changes
Mar 28, 2020
Emantor
suggested changes
Mar 28, 2020
| runHook postInstall | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { |
| runHook postInstall | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
There is no maintainer here, maybe add yourself?
There was a problem hiding this comment.
I was not sure if I should fill myself. But I will give it a try.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
alsa-lib is behind upstream and other alsa tools in nixpkgs. This PR adds to new packages
alsa-ucm-confandalsa-topology-confto reflect upstream's split to multiple repositories. Their content is linked into alsa-lib$out/share/alsadirectory, where alsa searches them.It looks like new alsa-lib is needed by new sof drivers to fully support sound in newer intel notebooks like mine (tested with custom nixos build).
https://bugzilla.redhat.com/show_bug.cgi?id=1772498
https://bugzilla.kernel.org/show_bug.cgi?id=201251
I removed some obsolete seds chaning
u_inttouint. Upstream has fixed this some time ago. And the last remaining is probaly not needed anymore too.Replaces #74102
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)