Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlexNG] Honor stretched items' specified min/max sizes #22378

Merged
merged 1 commit into from Mar 23, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 21, 2020

A stretched item's pre-flex layout was getting a fixed cross size equal
to the container's cross size, ignoring the item's min/max cross size.

Bug: 845235
Change-Id: I8ff2c160f6ede952297ac4f114e954d8dcc5538e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113809
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752613}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

A stretched item's pre-flex layout was getting a fixed cross size equal
to the container's cross size, ignoring the item's min/max cross size.

Bug: 845235
Change-Id: I8ff2c160f6ede952297ac4f114e954d8dcc5538e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113809
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752613}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants