Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build octave on macos #83185

Merged
merged 1 commit into from Mar 23, 2020
Merged

Build octave on macos #83185

merged 1 commit into from Mar 23, 2020

Conversation

idontgetoutmuch
Copy link
Contributor

Motivation for this change
bash-3.2$ nix-env -i octave
installing 'octave-5.1.0'
error: Package ‘qt-4.8.7’ in /nix/store/gfnyc1cd18agalcdvcia0w58kvggpqxq-nixpkgs-19.09pre185562.00ef72610c8/nixpkgs/pkgs/development/libraries/qt-4.x/4.8/default.nix:230 is not supported on ‘x86_64-darwin’, refusing to evaluate.

I followed the suggestions here:
https://savannah.gnu.org/bugs/?53627

and also what is done for homebrew:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/octave.rb#L92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 23, 2020
@ofborg ofborg bot requested a review from 7c6f434c March 23, 2020 06:51
@7c6f434c
Copy link
Member

Not sure if having some CLI-only version on Darwin (with -iA used to pick one or the other) would be a good idea, but well, it is a no-op on Linux and seems to fix something on macOS.

@7c6f434c 7c6f434c merged commit db4ccdd into NixOS:master Mar 23, 2020
@idontgetoutmuch idontgetoutmuch deleted the octave-for-macos branch March 23, 2020 08:19
@idontgetoutmuch idontgetoutmuch restored the octave-for-macos branch March 23, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@idontgetoutmuch @7c6f434c