py3-prep: fix map with list comprehensions #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In py2, map returned a list; in py3, it returns an iterator, which can't be indexed. Per upstream guidelines [1], while it is possible to just add a list() cast, it's more idiomatic to use a list comprehension for mapping. This is more pythonic regardless, and still py2 compatible. Partial progress towards NixOS#29 CC @grahamc @AmineChikhaoui [1] https://docs.python.org/3.0/whatsnew/3.0.html#views-and-iterators-instead-of-lists
bhipple
commented
Mar 22, 2020
| @@ -31,7 +31,8 @@ def __init__(self, xml, config): | |||
| self.private_zone = config["privateZone"] | |||
| self.zone_name = config["name"] | |||
| self.associated_vpcs = config["associatedVPCs"] | |||
| map(lambda x: x.pop("_module"), self.associated_vpcs) | |||
| for vpc in self.associated_vpcs: | |||
| vpc.pop("_module") | |||
There was a problem hiding this comment.
This is the "tricky case" mentioned in https://docs.python.org/3.0/whatsnew/3.0.html#views-and-iterators-instead-of-lists where we don't actually care about the list coming back. Implemented the swap to a for loop, as upstream recommends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In py2, map returned a list; in py3, it returns an iterator, which can't be indexed.
Per upstream guidelines [1], while it is possible to just add a list() cast,
it's more idiomatic to use a list comprehension for mapping. This is more
pythonic regardless, and still py2 compatible.
Partial progress towards #29
CC @grahamc @AmineChikhaoui
[1] https://docs.python.org/3.0/whatsnew/3.0.html#views-and-iterators-instead-of-lists