Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixops-aws
base: 51d61d9001cb
Choose a base ref
...
head repository: NixOS/nixops-aws
compare: 3cf582fcf624
Choose a head ref
  • 2 commits
  • 6 files changed
  • 2 contributors

Commits on Mar 22, 2020

  1. py3-prep: fix map with list comprehensions 

    In py2, map returned a list; in py3, it returns an iterator, which can't be indexed.

Per upstream guidelines [1], while it is possible to just add a list() cast,
it's more idiomatic to use a list comprehension for mapping. This is more
pythonic regardless, and still py2 compatible.

Partial progress towards #29

CC @grahamc @AmineChikhaoui

[1] https://docs.python.org/3.0/whatsnew/3.0.html#views-and-iterators-instead-of-lists
    @bhipple
    bhipple committed Mar 22, 2020
    Copy the full SHA
    7d1406c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #35 from bhipple/py3/map 

    py3-prep: fix map with list comprehensions
    @grahamc
    grahamc committed Mar 22, 2020
    Copy the full SHA
    3cf582f View commit details
    Browse the repository at this point in the history