py3 prep: foo.values() does not return an indexable list #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casting to a list is a no-op in py2, but in py3 we cannot index [0] without it. Partial progress towards NixOS#29. This commit also removes unused imports from test case files as a general cleanup.
|
Only changes test files, and the build is green on py2, so should be safe; plus trivial to review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting to a list is a no-op in py2, but in py3 we cannot index [0] without it.
Partial progress towards #29.
This commit also removes unused imports from test case files as a general cleanup.
CC @grahamc @AmineChikhaoui