Bugfix: known_hosts update on nixops destroy #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the nixops-aws plugin was always calling `known_hosts.update(old, new, val)`. As of this commit [1], all arguments to the `update` function must be non-null. While we could modify the `update` function in nixops to have the previous behavior, it makes more sense for us to just call `add` when we mean add, and `remove` when we mean remove. [1] NixOS/nixops#1233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the nixops-aws plugin was always calling
known_hosts.update(old, new, val).As of this commit [1], all arguments to the
updatefunction must be non-null.While we could modify the
updatefunction in nixops to have the previousbehavior, it makes more sense for us to just call
addwhen we mean add, andremovewhen we mean remove.[1] NixOS/nixops#1233
CC @grahamc @TheWizardTower