Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixops-aws
base: d1f9cccad954
Choose a base ref
...
head repository: NixOS/nixops-aws
compare: 27e33041603c
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Mar 22, 2020

  1. Bugfix: known_hosts update on nixops destroy 

    Previously, the nixops-aws plugin was always calling
`known_hosts.update(old, new, val)`.

As of this commit [1], all arguments to the `update` function must be non-null.
While we could modify the `update` function in nixops to have the previous
behavior, it makes more sense for us to just call `add` when we mean add, and
`remove` when we mean remove.

[1] NixOS/nixops#1233
    @bhipple
    bhipple committed Mar 22, 2020
    Copy the full SHA
    395079c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #38 from bhipple/bug/known-hosts 

    Bugfix: known_hosts update on nixops destroy
    @grahamc
    grahamc committed Mar 22, 2020
    Copy the full SHA
    27e3304 View commit details
    Browse the repository at this point in the history