Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flake8-future-import: 0.4.5 -> 0.4.6 and fix build #83170

Merged
merged 1 commit into from Mar 23, 2020
Merged

pythonPackages.flake8-future-import: 0.4.5 -> 0.4.6 and fix build #83170

merged 1 commit into from Mar 23, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 23, 2020

The build is currently broken on master and 20.03. This upgrades to the latest
version and also disables the bad py2 test. I spent a long time trying to figure
out what the issue is, but since it's disabled upstream on python3 anyways let's
just skip it on python2 as well.

ZHF: #80379

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
pythonPackages.flake8-future-import: 0.4.5 -> 0.4.6 and fix build
e997938 
The build is currently broken on master and 20.03. This upgrades to the latest
version and also disables the bad py2 test. I spent a long time trying to figure
out what the issue is, but since it's disabled upstream on python3 anyways let's
just skip it on python2 as well.

ZHF: NixOS#80379
@bhipple
Copy link
Contributor Author

bhipple commented Mar 23, 2020 

[9 built, 159 copied (390.7 MiB), 75.2 MiB DL]
5 package built:
esphome esptool python27Packages.flake8-future-import python37Packages.flake8-future-import python38Packages.flake8-future-import

Passes nixpkgs-review

@bhipple
Copy link
Contributor Author

bhipple commented Mar 23, 2020

CC @NixOS/nixos-release-managers

jonringer
jonringer approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[7 built, 1 copied (11.6 MiB), 3.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83170
5 package built:
esphome esptool python27Packages.flake8-future-import python37Packages.flake8-future-import python38Packages.flake8-future-import

@jonringer jonringer merged commit 3248eac into NixOS:master Mar 23, 2020
@bhipple bhipple mentioned this pull request Mar 24, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @jonringer