Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixops-aws
base: 9e8bfa1311e4
Choose a base ref
...
head repository: NixOS/nixops-aws
compare: 51d61d9001cb
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 22, 2020

  1. py3 prep: replacing iteritems and itervalues

    In python3, `dict.items()` and `dict.values()` are iterators by defualt, so the
    `iteritems` functions have been removed. In python2, these return a copy of the
    keys, which has small runtime penalty but is unlikely to be material for NixOps.
    
    Changing it to just `.items()` makes us both py2 and py3 compatible and prepares
    us for the migration #29.
    bhipple committed Mar 22, 2020
    Copy the full SHA
    484efad View commit details
    Browse the repository at this point in the history
  2. Merge pull request #33 from bhipple/feature/py3-prep

    py3 prep: replacing iteritems and itervalues
    grahamc committed Mar 22, 2020
    Copy the full SHA
    51d61d9 View commit details
    Browse the repository at this point in the history