Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pydf: install man page and default config file #83159

Merged
merged 1 commit into from Mar 26, 2020
Merged

pydf: install man page and default config file #83159

merged 1 commit into from Mar 26, 2020

Conversation

khumba
Copy link
Contributor

@khumba khumba commented Mar 22, 2020

This makes the pydf derivation install the package's man page and default config
file, so that man pydf works and the user has a default config file to work
from. This default config file is placed in share/pydf/ and isn't read by
default; pydf still looks in /etc and $HOME instead. (The file is identical
to the defaults in the executable itself except for additional colours applied
to the full_fs_colour setting.)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    • Not applicable.
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • The difference in closure size as reported by path-info -S is 5408 (bytes?).
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@khumba
pydf: install man page and default config file
7ca75fa 
This makes the pydf derivation install the package's man page and default config
file, so that `man pydf` works and the user has a default config file to work
from.  This default config file is placed in `share/pydf/` and isn't read by
default; pydf still looks in `/etc` and `$HOME` instead.  (The file is identical
to the defaults in the executable itself except for additional colours applied
to the `full_fs_colour` setting.)
@ofborg ofborg bot requested a review from monsieurp March 22, 2020 21:08
@matthewbauer matthewbauer merged commit e003ae1 into NixOS:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurp monsieurp Awaiting requested review from monsieurp

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khumba @matthewbauer