Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XPath: Add XPathNSResolver callback interface tests #22384

Merged
merged 3 commits into from Mar 25, 2020
Merged

XPath: Add XPathNSResolver callback interface tests #22384

merged 3 commits into from Mar 25, 2020

Conversation

shvaikalesh
Copy link
Member

See also #15105, #18390.

annevk
annevk approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Did you file bugs on all failures here or are there no failures for the XPath bits?

@shvaikalesh
Copy link
Member Author

shvaikalesh commented Mar 24, 2020 •
edited

Firefox implements callback interface properly, but throws SyntaxError instead of NamespaceError (like Safari and Chrome do). I did not manage to find exact error type in the spec though.

Both Safari and Chrome try to call "lookupNamespaceURI" method first, instead of checking if resolver is a function. They also make errors from abrupt completions visible to a developer, but not via "error" event like Firefox does.

Bugs:

@annevk
Copy link
Member

annevk commented Mar 25, 2020

https://dom.spec.whatwg.org/#xpath is all the specification we have at the moment. If you're interested in writing algorithms in English, that could be a fun project to work on.

Appreciate you filing all those bugs by the way!

@annevk annevk merged commit ee44ef0 into web-platform-tests:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger left review comments

@annevk annevk annevk approved these changes

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@deniak deniak Awaiting requested review from deniak

@jdm jdm Awaiting requested review from jdm

@plinss plinss Awaiting requested review from plinss

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@jdm jdm

Labels
cssom-view dom domxpath wg-css wg-dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shvaikalesh @annevk @Ms2ger @jdm @wpt-pr-bot