Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: SSH public key creation has to be encoded into bytes #39

Merged
merged 1 commit into from Mar 22, 2020
Merged

Bugfix: SSH public key creation has to be encoded into bytes #39

merged 1 commit into from Mar 22, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 22, 2020 •
edited

In python3, the boto connection needs to take this as bytes. Missed this change for #29.

Also removes two unused variables nearby, which cause linter warnings.

CC @grahamc

@bhipple
Bugfix: SSH public key creation has to be encoded into bytes
abf6147 
In python3, the boto connection needs to take this as bytes.

Also removes two unused variables nearby, which cause linter warnings.
@grahamc grahamc merged commit fb110b8 into NixOS:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @grahamc