-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recv_slice for RawSocket, IcmpSocket and UdpSocket may lose data #330
Comments
Good catch! I seem to have overlooked that while adding these functions. It is possible to use What we should do in this case is an interesting question. The Therefore I argue that it should return an error (probably |
I this still an issue? |
cc @Dirbaio |
Fixed by #859. |
recv_slice
for RawSocket, IcmpSocket and UdpSocket may lose data if the provided buffer is smaller than the packet to dequeue.I don't know if it should not dequeue and return an error, as it might not be possible to get a bigger slice when lacking an allocator, or stay with current behavior. However I think the documentation should be clearer as it seems to say nothing about that.
The text was updated successfully, but these errors were encountered: