Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python39Full: fix to use Python 3.9 rather than 3.8 #83124

Merged
merged 1 commit into from Mar 22, 2020

Conversation

gnprice
Copy link
Contributor

@gnprice gnprice commented Mar 22, 2020

Motivation for this change

python39Full was actually providing a build of Python 3.8. Looks like this was a typo when python39 was added in 648152f.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Looks like this was a typo when python39 was added in 648152f.
@roberth
Copy link
Member

roberth commented Mar 22, 2020

Thank you!

@roberth
Copy link
Member

roberth commented Mar 22, 2020

Backported to 20.03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants