py3 prep: relative imports and exception syntax #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This runs two more fixes that are safe to merge in python2 for continued progress towards NixOS#29: 1. Converting `except T, R` to `except T as R`. Both work in python2, but only the latter works in python3. https://docs.python.org/3.0/whatsnew/3.0.html#changed-syntax 2. Converting module imports to relative imports.
grahamc
approved these changes
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs two more fixes that are safe to merge in python2 for continued
progress towards #29:
Converting
except T, Rtoexcept T as R. Both work in python2, but onlythe latter works in python3.
https://docs.python.org/3.0/whatsnew/3.0.html#changed-syntax
Converting module imports to relative imports.
CC @grahamc @AmineChikhaoui