Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atlassian-jira: 8.7.1 -> 8.8.0 #83014

Closed
wants to merge 1 commit into from
Closed

atlassian-jira: 8.7.1 -> 8.8.0 #83014

wants to merge 1 commit into from

Conversation

basilgood
Copy link
Contributor

@basilgood basilgood commented Mar 20, 2020 •
edited

update package;
fix awk dependency when services.jira.jrePackage = pkgs.jdk11

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basilgood
atlassian-jira: 8.7.1 -> 8.8.0
097479d 
update package;
fix awk dependency when services.jira.jrePackage = pkgs.jdk11
@ofborg ofborg bot requested review from fpletz, ciil and globin March 20, 2020 17:40
ciil
ciil suggested changes Mar 22, 2020
View reviewed changes
pkgs/servers/atlassian/jira.nix
@@ -30,6 +36,9 @@ stdenv.mkDerivation rec {

installPhase = ''
cp -rva . $out
for f in $out/bin/*.sh; do
wrapProgram $f --prefix PATH : ${stdenv.lib.makeBinPath [ gawk ]}
done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapping seems to be interfering with starting jira in my test deployment, both with openjdk and oraclejdk. How did you test this?

Copy link
Contributor Author

@basilgood basilgood Mar 23, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review.
I'm sorry to have wasted your time.
I made a mistake.
I'll be back with a good job.

@basilgood basilgood closed this Mar 23, 2020
@basilgood basilgood deleted the feature/atlassian-jira-fix-and-update branch March 23, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciil ciil ciil requested changes

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basilgood @ciil