Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.37.0 -> 0.38.1 #83179

Merged
merged 1 commit into from Mar 23, 2020
Merged

starship: 0.37.0 -> 0.38.1 #83179

merged 1 commit into from Mar 23, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbigras
Copy link
Contributor

bbigras commented Mar 23, 2020

I don't seem able to build it

with nix-review

[...]
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/bbigras/.cache/nixpkgs-review/pr-83179/build.nix
builder for '/nix/store/r4ayg0d5wzxs1g3k82mnpzkphvn0xr80-starship-0.38.1.drv' failed with exit code 101; last 10 log lines:
  It looks like you're compiling on Linux and also targeting Linux. Currently this
  requires the `pkg-config` utility to find OpenSSL but unfortunately `pkg-config`
  could not be found. If you have OpenSSL installed you can likely fix this by
  installing `pkg-config`.
  
  ', /build/starship-0.38.1-vendor.tar.gz/openssl-sys/build/find_normal.rs:150:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
  
  warning: build failed, waiting for other jobs to finish...
  error: build failed
cannot build derivation '/nix/store/yj156ira1qg1v6w0hf5vz2170rmyg5z4-env.drv': 1 dependencies couldn't be built
[2 built (1 failed), 122 copied (1315.5 MiB), 347.6 MiB DL]
error: build of '/nix/store/yj156ira1qg1v6w0hf5vz2170rmyg5z4-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/83179
1 package failed to build:
starship

normally

error: failed to run custom build command for `openssl-sys v0.9.54`

Caused by:
  process didn't exit successfully: `/build/source/target/release/build/openssl-sys-fcf5ef1f7a4e925f/build-script-main` (exit code: 101)
--- stdout
cargo:rustc-cfg=const_fn
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=OPENSSL_LIB_DIR
OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=OPENSSL_INCLUDE_DIR
OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR unset
cargo:rerun-if-env-changed=OPENSSL_DIR
OPENSSL_DIR unset
run pkg_config fail: "Failed to run `\"pkg-config\" \"--libs\" \"--cflags\" \"openssl\"`: No such file or directory (os error 2)"

--- stderr
thread 'main' panicked at '

Could not find directory of OpenSSL installation, and this `-sys` crate cannot
proceed without this knowledge. If OpenSSL is installed and this crate had
trouble finding it,  you can set the `OPENSSL_DIR` environment variable for the
compilation process.

Make sure you also have the development packages of openssl installed.
For example, `libssl-dev` on Ubuntu or `openssl-devel` on Fedora.

If you're in a situation where you think the directory *should* be found
automatically, please open a bug at https://github.com/sfackler/rust-openssl
and include information about your system as well as this message.

$HOST = x86_64-unknown-linux-gnu
$TARGET = x86_64-unknown-linux-gnu
openssl-sys = 0.9.54


It looks like you're compiling on Linux and also targeting Linux. Currently this
requires the `pkg-config` utility to find OpenSSL but unfortunately `pkg-config`
could not be found. If you have OpenSSL installed you can likely fix this by
installing `pkg-config`.

', /build/starship-0.38.1-vendor.tar.gz/openssl-sys/build/find_normal.rs:150:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

@bbigras
Copy link
Contributor

bbigras commented Mar 23, 2020

It builds if I use:

buildInputs = stdenv.lib.optionals stdenv.isDarwin [ libiconv Security ] ++ [ pkg-config openssl ];

@marsam
Copy link
Contributor Author

marsam commented Mar 23, 2020

sorry about that, it should be fixed now

bbigras
bbigras approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@bbigras bbigras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and runs fine. thanks 👍

@marsam marsam merged commit f85d4e9 into NixOS:master Mar 23, 2020
@marsam marsam deleted the update-starship branch March 23, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras bbigras approved these changes

@davidtwco davidtwco Awaiting requested review from davidtwco

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @bbigras