Migrate nixops-aws to python3 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does a 1-way migration to python3, and fully resolves NixOS#29. Aside from the `release.nix`, there are no manual changes in this PR. It was generated with: 2to3 -n -w nixopsaws/**/*.py -x dict -x print black . We have already fixed the `print` function in a previous PR, as well as all of the dictionary iterators. `2to3` is not particularly smart about this and will add a `list()` cast just about everywhere otherwise.
|
I have built this w/ python3 against the latest That said, the remaining diff in this PR should be very readable and easy to understand. |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a 1-way migration to python3, and fully resolves #29.
Aside from the
release.nix, there are no manual changes in this PR. It wasgenerated with:
We have already fixed the
printfunction in a previous PR, as well as all ofthe dictionary iterators.
2to3is not particularly smart about this and willadd a
list()cast just about everywhere otherwise.CC @grahamc @AmineChikhaoui