redo-apenwarr: switch to python3 and fix building man #83134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ck3d
force-pushed
the
redo-apenwarr-python3
branch
from
ec84354
to
85fa747
Compare
markuskowa
reviewed
Mar 22, 2020
pkgs/development/tools/build-managers/redo-apenwarr/default.nix
Outdated
Show resolved
Hide resolved
Removed dependency to mkdoc, which is only needed to build the webpage.
ck3d
force-pushed
the
redo-apenwarr-python3
branch
from
85fa747
to
4c9bd5d
Compare
|
We raced each other! I was about to send the same PR :). Just for the record: upstream released 0.42a specifically for python3 support, so the upgrade here is not to HEAD per se, but to the next official upstream release. Thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed dependency to mkdoc, which is only needed to build the webpage.
Python3 is not supported in 0.42, so I had to update to current master.
Motivation for this change
switch to python3
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)