Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argocd: init at 1.4.2 #79846

Merged
merged 1 commit into from Feb 13, 2020
Merged

argocd: init at 1.4.2 #79846

merged 1 commit into from Feb 13, 2020

Conversation

shahrukh330
Copy link
Contributor

@shahrukh330 shahrukh330 commented Feb 11, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ehmry February 11, 2020 18:10
@shahrukh330 shahrukh330 changed the title argocd-cli: init at 1.3.0 argocd: init at 1.3.0 Feb 11, 2020
@shahrukh330 shahrukh330 changed the title argocd: init at 1.3.0 argocd: init at 1.4.1 Feb 12, 2020
@shahrukh330 shahrukh330 changed the title argocd: init at 1.4.1 argocd: init at 1.4.2 Feb 12, 2020
@ofborg ofborg bot requested a review from kalbasit February 12, 2020 17:45
kalbasit
kalbasit reviewed Feb 13, 2020
View reviewed changes
pkgs/applications/networking/cluster/argocd/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/cluster/argocd/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/cluster/argocd/use-go-module.patch
@@ -0,0 +1,3058 @@
diff --git a/Gopkg.lock b/Gopkg.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is generating this patch reproducible? Should we include an update.sh in this directory to get it to generate a patch on the fly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not reproducible at the moment. I had to manually fix broken dependencies in go.mod after doing go mod init

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Let's submit the patch to the upstream project then.

@kalbasit
Copy link
Member

@GrahamcOfBorg build argocd

@ofborg ofborg bot requested a review from kalbasit February 13, 2020 19:05
@kalbasit kalbasit merged commit be16359 into NixOS:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shahrukh330 @kalbasit