Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkdocs: default to Python 3 #79913

Merged
merged 1 commit into from Mar 6, 2020
Merged

mkdocs: default to Python 3 #79913

merged 1 commit into from Mar 6, 2020

Conversation

jethrokuan
Copy link
Contributor

@jethrokuan jethrokuan commented Feb 12, 2020

Motivation for this change

mkdocs in master doesn't build. nix-shell -p mkdocs gives:

[jethro@jethro-desktop:~/nix-config/nixpkgs]$ nix-shell -p mkdocs
error: Django-2.2.10 not supported for interpreter python2.7
(use '--show-trace' to show detailed location information)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the parameter in development/tools/documentation/mkdocs/default.nix to python3 instead

@FRidh FRidh added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 12, 2020
@jethrokuan
Copy link
Contributor Author

I hope I did it right

@ofborg ofborg bot requested a review from rkoe February 12, 2020 11:08
@jethrokuan
Copy link
Contributor Author

Just bumping this.

@FRidh FRidh merged commit ee17a6a into NixOS:master Mar 6, 2020
@jethrokuan jethrokuan deleted the fix/mkdocs branch March 6, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants