Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.gsconnect: fix build #79845

Merged
merged 1 commit into from Feb 11, 2020
Merged

gnomeExtensions.gsconnect: fix build #79845

merged 1 commit into from Feb 11, 2020

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Feb 11, 2020

Motivation for this change

dbus is now propagated from at-spi2-core, which made gsconnect try to
install dbus service files in the wrong location.

closes #79806

Things done

Running with this version successfully.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
gnomeExtensions.gsconnect: fix build
71a54f1 
dbus is now propagated from at-spi2-core, which made gsconnect try to
install dbus service files in the wrong location.

closes NixOS#79806
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 11, 2020
@ofborg ofborg bot requested a review from etu February 11, 2020 17:30
jtojnar
jtojnar approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffing the directory structure with the one from previous nixos-unstable looks okay.

@jtojnar jtojnar merged commit d40256f into NixOS:master Feb 11, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Feb 11, 2020

Thanks.

@worldofpeace
Copy link
Contributor

Backport?

@hedning
Copy link
Contributor Author

hedning commented Feb 12, 2020

Right, looks like 20.03 will need this, as acdb256 went in.

@hedning hedning deleted the gsconnect-fix-build branch February 12, 2020 02:33
@hedning hedning added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gnomeExtensions.gsconnect build error on master
3 participants
@hedning @jtojnar @worldofpeace