Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gunicorn: add 19.x branch for python2.7 support [20.03] #79856

Merged
merged 1 commit into from Feb 11, 2020
Merged

gunicorn: add 19.x branch for python2.7 support [20.03] #79856

merged 1 commit into from Feb 11, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Feb 11, 2020 •
edited

Backport of #79782. @jonringer, want me to change the commit msg or keep it same as the master commit?

The nixos/moinmoin module uses gunicorn, however the 20.0 version dropped python2 support which broke the module as there's no python3 port planned for moinmoin: http://moinmo.in/Python3

Motivation for this change

nix-build nixos/tests/moinmoin.nix fails

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata
gunicorn: add 19.x branch for python2.7 support
96f63e0 
The nixos/moinmoin module uses gunicorn, however the 20.0 version
dropped python2 support which broke the module as there's no python3
port planned for moinmoin: http://moinmo.in/Python3

(cherry picked from commit d202e9e)
@jonringer
Copy link
Contributor

did we already do the 20.03 branch off?

@jonringer
Copy link
Contributor

cc @worldofpeace

@FRidh
Copy link
Member

FRidh commented Feb 11, 2020

yes

@FRidh FRidh merged commit d903c89 into NixOS:release-20.03 Feb 11, 2020
@mmilata mmilata deleted the gunicorn-python27-20.03 branch February 11, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmilata @jonringer @FRidh